Add Edit Board mode for drag/resize of boards with explicit width/height#719
Open
mendarb wants to merge 1 commit intotscircuit:mainfrom
Open
Add Edit Board mode for drag/resize of boards with explicit width/height#719mendarb wants to merge 1 commit intotscircuit:mainfrom
mendarb wants to merge 1 commit intotscircuit:mainfrom
Conversation
…height When a board has explicit width/height (not an outline polygon), an "Edit Board" button appears in the toolbar. Clicking it enables a mode where the board can be dragged to offset its center and resized via 8 edge/corner handles. Board edits are tracked in local viewer state and exposed through an onBoardChanged callback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mendarb
requested review from
Abse2001,
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #106
Summary
in_edit_board_modestate to the global store with"edit_board"as a new edit modeEditBoardOverlaycomponent that renders a dashed green border and 8 resize handles around the board when in edit modewidth/heightwhile keeping the opposite edge fixed"Edit Board"button toToolbarOverlay(only shown when the board has explicitwidth/height, not an outline polygon)PCBViewerstate and exposed through a newonBoardChangedcallback propedit-board.fixture.tsxdemo fixtureHow it works
width/height(no outline polygon) -> "Edit Board" button appears in toolbarwidth/heightwhile keeping opposite edge fixedFiles changed
src/lib/board-editing.ts- Board editing utilities (getEditableBoard, resizeEditableBoard, applyEditableBoard)src/components/EditBoardOverlay.tsx- Overlay component for drag/resize interactionsrc/global-store.ts- Addedin_edit_board_modestate and"edit_board"modesrc/components/ToolbarOverlay.tsx- Added "Edit Board" toolbar buttonsrc/components/CanvasElementsRenderer.tsx- Wired EditBoardOverlay into the component treesrc/PCBViewer.tsx- Added board override state andonBoardChangedpropTest
npx tsc --noEmit- cleannpm run build- cleannpm run format:check- cleanGenerated with Claude Code