Fix inner-layer copper pour rendering#737
Conversation
techmannih
requested review from
Abse2001,
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| for (const { canvas, copperLayer } of copperLayers) { | ||
| if (!canvas) continue | ||
| drawCopperPourElementsForLayer({ | ||
| canvas: bottomCanvas, |
|
when selecting a layer except top and bottom the pout is not translucent it's solid, make them like top and bottom |
|
@Abse2001 so how it should be works for the inner layers? |
|
like top and bottom always transparent but when selected add more opacity and render on top , look how top and bottom layers look when selected and not |
|
yes, I checked this in circuit-to-canvas. Currently, only the top and bottom layer copper colors are defined with a lighter (translucent) appearance, which is why their pours look transparent. Inner layers don’t have this defined, so their pours appear solid. We should apply the same translucent color logic to the inner layers to keep the behavior consistent. Right? |
|
Currently, top and bottom layers use an opacity of 0.5, which makes their pours translucent, while all other layers use 1, making them fully solid. Because of this, inner layers appear solid instead of translucent. We should apply the same opacity (e.g., 0.5) to inner layers as well to make the rendering consistent across all layers./ |
|
OK let's patch circuit to canvas first? |
3 participants
test : https://pcb-viewer-7xytbyoag-tscircuit.vercel.app/?fixture=%7B%22path%22%3A%22src%2Fexamples%2F2026%2Frepros%2Finner-layer-copper-pours.fixture.tsx%22%7D
top,inner1-inner6, andbottom