Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+45
to
+51
| test("supports autorouter version v5", () => { | ||
| const result = subcircuitGroupPropsWithBool.parse({ | ||
| subcircuit: true, | ||
| autorouterVersion: "v5", | ||
| }) | ||
| expect(result.autorouterVersion).toBe("v5") | ||
| }) |
Contributor
There was a problem hiding this comment.
This test file violates the rule that a *.test.ts file may have AT MOST one test(...) function. The file already contains at least one test() function (visible in the context at line 42), and this modification adds a second test() function on line 45. To fix this violation, split the tests into multiple numbered files such as autorouter1.test.ts and autorouter2.test.ts, with each file containing only one test() function.
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v5so consumers can specify the new autorouter runtime.Description
"v5"to theautorouterVersionTypeScript union inlib/components/group.ts.subcircuitGroupPropsto accept"v5"(inlib/components/group.ts).tests/autorouter.test.tsassertingautorouterVersion: "v5"parses correctly.generated/COMPONENT_TYPES.md,generated/PROPS_OVERVIEW.md,README.md).Testing
bun scripts/generate-component-types.ts,bun scripts/generate-manual-edits-docs.ts,bun scripts/generate-readme-docs.ts, andbun scripts/generate-props-overview.ts(succeeded).bun test tests/autorouter.test.tswhich passed: 8 tests, 0 failures.bunx tsc --noEmit(succeeded).bun run format(succeeded).Codex Task