Render progress tooltip for async effects and expose activeAsyncEffects to preview#3031
Open
Render progress tooltip for async effects and expose activeAsyncEffects to preview#3031
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ActiveAsyncEffecttype andactiveAsyncEffects?: ActiveAsyncEffect[]toPreviewContentPropsinPreviewContentProps.tsto describe running async effects.RenderProgressTooltipcomponent (RenderProgressTooltip.tsx) that renders the progress percentage, the active phase/name, and a tooltip listing running async effects with durations and component context.CircuitJsonPreview.tsxwith the newRenderProgressTooltipand wiredactiveAsyncEffectsandisRunningCodeprops to it.RunFrame.tsxto use theActiveAsyncEffecttype for itsactiveAsyncEffectsstate, expose a sortedactiveAsyncEffectsList, and pass that list intoCircuitJsonPreviewasactiveAsyncEffectsalong withactiveEffectNameandisRunningCode.Testing
tsc --noEmitto validate API and prop changes, which succeeded.yarn build) to ensure the new component and imports compile, which succeeded.yarn test) and unit tests (where present), and they passed.Codex Task