Skip to content

fix: remove duplicate consecutive points in solver #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yutubeboss575-create wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove duplicate consecutive points in solver #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...ematicTraceLinesSolver/SchematicTraceSingleLineSolver2/SchematicTraceSingleLineSolver2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,25 +132,32 @@ export class SchematicTraceSingleLineSolver2 extends BaseSolver {
const [PA, PB] = this.pins
const collision = findFirstCollision(path, this.obstacles)

if (!collision) {
if (!collision) {
// Sanity check: ensure path still connects PA -> PB
const first = path[0]!
const last = path[path.length - 1]!
const EPS = 1e-9
const samePoint = (p: Point, q: Point) =>
Math.abs(p.x - q.x) < EPS && Math.abs(p.y - q.y) < EPS

if (
samePoint(first, { x: PA.x, y: PA.y }) &&
samePoint(last, { x: PB.x, y: PB.y })
) {
this.solvedTracePath = path
// Issue #78 Fix: Üst üste binen (duplicate) noktaları temizle
const cleanPath: Point[] = []
for (let i = 0; i < path.length; i++) {
if (i === 0 || !samePoint(path[i]!, path[i - 1]!)) {
cleanPath.push(path[i]!)
}
}
this.solvedTracePath = cleanPath
this.solved = true
}
return
}

let { segIndex, rect } = collision

// Never move the first or last segments - move adjacent segment instead
const isFirstSegment = segIndex === 0
const isLastSegment = segIndex === path.length - 2
Expand Down
Loading