streamline things for a Homebrew tap#20
Merged
Merged
Conversation
Contributor
Author
|
As far as I see, this PR contains everything in #14, too |
Contributor
Author
|
@tscrim - it's not too urgent, but would be nice to clean up before Sage 10.10 |
tscrim
approved these changes
Jun 11, 2026
tscrim
left a comment
tscrim
left a comment
Owner
There was a problem hiding this comment.
I don't know about the homebrew stuff, but I trust you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to make a Homebrew tap for coxeter, but it's too messy as it is now, so I applied Sage's patched to the trunk, and also did few simplifications and de-Saging (created a makefile rule to fill in a template,
s/SAGE_LOCAL/PREFIX.Now to install to
/foo/barone can just runsmake install PREFIX=/foo/barOn Homebrew it can be installed by doing
brew install dimpase/tap/coxeter3.(and the formula is here: https://github.com/dimpase/homebrew-tap/blob/main/Formula/c/coxeter3.rb)
How about merging all this, and then we can update the Sage's spkg install too.