fix: remove hardcoded local JDK path from gradle.properties#69
Merged
Conversation
Agent-Logs-Url: https://github.com/tstapler/stelekit/sessions/235d9848-66c2-484c-8716-25399fefddd5 Co-authored-by: tstapler <3860386+tstapler@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
tstapler
May 3, 2026 19:28
View session
There was a problem hiding this comment.
Pull request overview
Removes a developer-specific org.gradle.java.home override from the repo’s shared gradle.properties so Gradle doesn’t fail on CI runners that don’t have that local JDK path. This aligns the build with the existing GitHub Actions setup that provisions a JDK explicitly.
Changes:
- Removed the hardcoded
org.gradle.java.home=/home/...entry (and related comments) fromgradle.properties.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All CI jobs were failing immediately because a developer's local JDK path was committed to
gradle.properties:This path doesn't exist on GitHub Actions runners, causing every Gradle invocation to abort with
Java home supplied is invalidbefore any build work could start.Removed the
org.gradle.java.homeoverride from the sharedgradle.properties. CI already provisions JDK 21 viaactions/setup-java@v4. Developers who need to pin the daemon JVM locally (e.g. to work around the Kotlin 2.0.20 + JDK 25 version-string parse crash) should setorg.gradle.java.homein their personal~/.gradle/gradle.propertiesinstead.