Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses the blank installer-progress window observed in v0.3.1/v0.3.2 by streaming setup log lines into the UI as the installer runs, moving the long-running install/uninstall work off the UI thread, and emitting structured per-step progress from InstallerStateMachine. It also revises the v0.3.3 release notes/README to drop the prior winget submission claim and adds tests for the new progress and log behavior.
Changes:
SetupLognow appends each line to disk immediately, exposes aLineWrittenevent, and serializes access with a lock;SetupStartupproduces the initial visible lines.InstallerStateMachineraisesProgressevents (Starting/Completed/Failed/Warning) per step and tags verification failures with their step;SetupFormsubscribes to bothLineWritten(to append to the UITextBoxviaBeginInvoke) andProgress, and wrapsInstallAsync/UninstallAsyncinTask.Runso the form can repaint.- Documentation rolled from v0.3.2 to v0.3.3, removing winget submission references and replacing the v0.3.2 release draft with v0.3.3.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PriorityGear.Setup/SetupLog.cs | Adds locking, immediate file append per line, and a LineWritten event. |
| src/PriorityGear.Setup/SetupStartup.cs | New helper producing the initial visible log lines and mode name. |
| src/PriorityGear.Setup/InstallerStateMachine.cs | New InstallerProgress/InstallerProgressKind and per-step Progress event with step-tagged Fail overload. |
| src/PriorityGear.Setup/Program.cs | Subscribes UI to log lines, runs install/uninstall on a background task, emits start banner, and logs progress events. |
| tests/PriorityGear.Setup.Tests/SetupLogTests.cs | Covers immediate flush, event invocation, and initial-line content. |
| tests/PriorityGear.Setup.Tests/InstallerStateMachineTests.cs | Covers success ordering, failure stop-on-error, and cleanup warning paths. |
| README.md / README.ja.md / docs/installer.md | Bump to v0.3.3 and remove winget submission references. |
| docs/release-drafts/v0.3.3.md | New v0.3.3 release notes focused on progress visibility fix. |
| docs/release-drafts/v0.3.2.md | Deleted prior v0.3.2 release draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.