Conversation
There was a problem hiding this comment.
Pull request overview
Registers PriorityGear in the machine-wide Start Menu as part of the installer flow, and updates documentation/release notes to describe the post-install launch path for v0.3.4.
Changes:
- Add Start Menu shortcut planning + creation during install, and deletion during uninstall.
- Extend
SetupInstallPlanwith GUI app + Start Menu paths and add tests for the shortcut spec. - Update README / installer docs and add v0.3.4 release draft.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/PriorityGear.Setup.Tests/SetupPlanningTests.cs | Adds assertions for AppExePath and validates Start Menu shortcut spec targets the installed GUI app. |
| src/PriorityGear.Setup/StartMenuShortcut.cs | Introduces Start Menu shortcut create/delete implementation and a ShortcutSpec record. |
| src/PriorityGear.Setup/SetupInstallPlan.cs | Adds AppExePath and Start Menu directory/shortcut path properties used by setup. |
| src/PriorityGear.Setup/Program.cs | Hooks Start Menu shortcut creation into install and deletion into uninstall, with logging. |
| README.md | Updates System Mode installer section to v0.3.4 and documents Start Menu launch path. |
| README.ja.md | Japanese README updates for v0.3.4 and Start Menu launch path. |
| docs/release-drafts/v0.3.4.md | Adds v0.3.4 release draft covering Start Menu registration and scope/safety notes. |
| docs/installer.md | Updates installer documentation for v0.3.4, including Start Menu launch instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
No elevated setup was run from Codex.