Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a silent uninstall edge case where the setup executable is launched from within the installed Program Files directory, ensuring uninstall cleanup can still complete and documenting the v0.3.5 release draft for WinGet lifecycle readiness.
Changes:
- Reorders uninstall cleanup to remove uninstall registration and Start Menu shortcut before removing installed program files.
- Adds delayed install-root deletion logic when setup is executing from inside the install directory.
- Adds v0.3.5 release draft notes describing the installer fix and distribution boundary.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/PriorityGear.Setup.Tests/SetupPlanningTests.cs | Adds tests that assert uninstall cleanup ordering and the presence of delayed-delete scheduling strings. |
| src/PriorityGear.Setup/Program.cs | Introduces RemoveInstallDirectory and schedules post-exit deletion when uninstall runs from the install root. |
| docs/release-drafts/v0.3.5.md | Adds release draft documenting the installer fix and scope/distribution notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation