Skip to content

Fix silent uninstall cleanup#18

Merged
tsuchim merged 2 commits into
mainfrom
devel
May 19, 2026
Merged

Fix silent uninstall cleanup#18
tsuchim merged 2 commits into
mainfrom
devel

Conversation

@tsuchim
Copy link
Copy Markdown
Owner

@tsuchim tsuchim commented May 19, 2026

Summary

  • fix silent uninstall when setup runs from the installed version directory
  • remove uninstall registration and Start Menu shortcut before install-root cleanup
  • add v0.3.5 release draft for the winget readiness fix

Validation

  • scripts/check-workflow-release-state.ps1
  • dotnet restore PriorityGear.slnx
  • dotnet build PriorityGear.slnx --configuration Release --no-restore
  • dotnet test PriorityGear.slnx --configuration Release --no-build
  • scripts/build-verification-installer.ps1
  • scripts/package-release.ps1 -TagName v0.3.5
  • scripts/inspect-release-artifacts.ps1 -TagName v0.3.5
  • elevated v0.3.5 candidate direct setup install/uninstall lifecycle passed

Copilot AI review requested due to automatic review settings May 19, 2026 12:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a silent uninstall edge case where the setup executable is launched from within the installed Program Files directory, ensuring uninstall cleanup can still complete and documenting the v0.3.5 release draft for WinGet lifecycle readiness.

Changes:

  • Reorders uninstall cleanup to remove uninstall registration and Start Menu shortcut before removing installed program files.
  • Adds delayed install-root deletion logic when setup is executing from inside the install directory.
  • Adds v0.3.5 release draft notes describing the installer fix and distribution boundary.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/PriorityGear.Setup.Tests/SetupPlanningTests.cs Adds tests that assert uninstall cleanup ordering and the presence of delayed-delete scheduling strings.
src/PriorityGear.Setup/Program.cs Introduces RemoveInstallDirectory and schedules post-exit deletion when uninstall runs from the install root.
docs/release-drafts/v0.3.5.md Adds release draft documenting the installer fix and scope/distribution notes.

Comment thread tests/PriorityGear.Setup.Tests/SetupPlanningTests.cs Outdated
Comment thread src/PriorityGear.Setup/Program.cs
@tsuchim tsuchim merged commit b44081c into main May 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants