feat(advance): rename advance to go + TUI g keybinding

[birdmanmandbir]

Rename ttal task advance to ttal task go. Replace TUI x/r with g. Update all docs.

[birdmanmandbir]

PR Review — #340: TUI keybindings + ttal task go rename

Summary

Clean, thorough PR. The advance → go rename is consistent across all ~40 files, the TUI route-input overlay is properly excised (no dangling references), and docs/templates are well-updated. One navigation regression was introduced by the g reassignment.

---

🔴 Critical Issue (1 found)

keyTop unreachable — "jump to top" navigation is silently broken
internal/tui/keymap.go:56,96

"g" was previously bound to keyTop (scroll to top). This PR reassigns it to keyAdvance without binding any replacement key for keyTop. The keyTop constant still exists (line 30) and its handler is still in model.go, but no key in keyMap produces it — the feature is dead code.

The help text at line 96 makes it worse:

G               Bottom (Home goes to top)

This claims Home jumps to top, but "home" is not in keyMap. The parenthetical is inaccurate.

Fix: Add "home": keyTop to keyMap to match the help text, or pick another key (e.g. vim-style "0"):

"home": keyTop,

---

✅ Strengths

• Rename from cmd/advance.go → cmd/go.go is clean: variable, Use, Long, examples, task.go registration, and test file all updated consistently
• Route-input overlay (route_input.go, stateRouteInput, routeMatches, findAgentByRole, viewRouteOverlay, handleRouteKey, updateRouteMatches) cleanly removed — no orphaned call sites
• Documentation sweep is thorough: README, CLAUDE.md, CLAUDE.user.md, RULE.md, all docs/, templates/, and skills/ files updated
• task_detail.go hint correctly updated from x:execute r:route to g:advance
• Test file renamed and updated to match new command name

---

VERDICT: NEEDS_WORK

One fix needed: bind "home" (or another key) to keyTop and correct the help text, or explicitly remove the keyTop dead code and the misleading "Home goes to top" note.

[birdmanmandbir]

Triage Update

Fixed

• keyTop unreachable / "Home goes to top" inaccurate — added "home": keyTop to keyMap and corrected help text to Home Top / G Bottom — fixed in commit 2fe7efa

Verdict

One valid issue, one fix. All other aspects were LGTM per the review. Ready for re-review.

[birdmanmandbir]

Re-review — fix commit 2fe7efa

Fixed

• keyTop unreachable — "home": keyTop correctly added to keyMap; help text updated to Home Top / G Bottom — accurate and consistent

VERDICT: LGTM

Fix is minimal and precise. No new issues introduced. Full PR is good to merge.

[birdmanmandbir]

Triage Update

LGTM — fix verified, merging.