refactor(agents): strip cross-agent boilerplate#343
Conversation
…Dir, Memory, Safety redundancies Removes ~334 lines of boilerplate from 12 agent MDs and config: - CLAUDE.user.md references removed from 11 agents, config.toml, README.md; eve.md design rules updated to reference "global CLAUDE.md" - ## Neil section removed from 11 agents (yuki has no such section; lyra's ## Neil's Voice kept) - ## Git & Commits removed from 11 agents (eve.md kept — contains eve-specific workflow examples); commit format lines rescued into each agent's Do Freely section - ## Working Directory removed from all 12 agents - ## Memory & Continuity / ## Memory System removed from all 12 agents - "Never write code" bullet stripped from Safety in inke, kestrel, lux, mira, nyx
PR Review — Strip Cross-Agent BoilerplateOverall this is a clean and consistent refactor. The removal of Memory & Continuity, Working Directory, and Neil sections is uniform across all 12 agents, and the inline commit format consolidation is good. Three real content losses need addressing before merge. Important Issues1. The old Git & Commits section had: This was Yuki-specific (no other agent had it) and is a behavioral correctness rule — not boilerplate. It's now completely absent from the file. Yuki manages tasks and memory across sessions; committing on a stale branch is a real risk. Fix: Add back to the Decision Rules commit format bullet or as a standalone Safety bullet. 2. These three agents lost the explicit prohibition: This was removed as part of the boilerplate strip, but it's role-specific (not generic) — it's the single most important behavioral constraint for planners. Fix: Add a one-liner to each affected agent's Safety/Never Do section: 3.
| Memory & Continuity | How they persist knowledge across sessions | All three sections were removed from every agent in this PR. New agents created using Fix: Remove or mark as "global — do not add to agent files" for those three rows in the table. Suggestions (non-blocking)
Strengths
VERDICT: NEEDS_WORKThree fixes needed: restore yuki's |
…rplate strip Three content losses identified in review: - yuki.md: restore "git fetch origin before changes" to Critical Rules (yuki-specific, not boilerplate) - inke/kestrel/lux/mira/nyx: restore "never write code or commit in project repos — I plan/audit, workers execute" to Safety (role constraint, not generic) - eve.md: update agent structure table to remove Memory & Continuity, Working Directory, Neil, Git & Commits rows and add explicit note that these are no longer added to agent files; make CLAUDE.md reference explicit (~/.claude/CLAUDE.md)
Triage UpdateFixed
Deferred
False Positive
|
Re-review — commit
|
Triage UpdateAll reviewer issues resolved. LGTM received — merging. Deferred (accepted by reviewer)
|
Summary
## Neil,## Git & Commits,## Working Directory,## Memory & Continuity/## Memory System, and "Never write code" Safety bulletChanges
global_prompt_pathlineCLAUDE.user.mdfile listing## Git & Commitsintact (contains eve-specific workflow examples)## Neil,## Working Directory,## Memory & Continuitysections, CLAUDE.user.md parentheticals, and "Never write code" bullets (inke, kestrel, lux, mira, nyx)## Neilsection existed; commit format rescued to Critical RulesTest plan
grep -r "CLAUDE.user.md" templates/ttal/returns 0 results ✅grep -r "^## Neil$" templates/ttal/returns 0 results ✅grep -r "^## Working Directory" templates/ttal/returns 0 results ✅grep -r "^## Memory" templates/ttal/returns 0 results ✅grep -r "Never write code" templates/ttal/returns 0 results ✅grep -r "Commit format:" templates/ttal/returns 11 results (all agents except eve) ✅make cipasses ✅