Make defaults sensible for windows, fix program finding.#5
Open
MHebes wants to merge 2 commits intotttapa:masterfrom
Open
Make defaults sensible for windows, fix program finding.#5MHebes wants to merge 2 commits intotttapa:masterfrom
MHebes wants to merge 2 commits intotttapa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the project! Just some things I came across when compiling on windows.
Uses
find_programinstead ofsetto find avr tools so that.exesuffix is added. Small behavior change: Does notFORCEthe cache variable change. Could get around this with afind_program(NO_CACHE)followed byset(CACHE FORCE)if you'd like, it just looks a little clunkier.Checks
CMAKE_HOST_WIN32to give a different default forARDUINO_PATH.Mentions issue about Visual Studio generators not respecting CMAKE_CXX_COMPILER.