Bump TerminalGuiVersion to 2.4.12-develop.14 (needs fixes)#258
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f377baf647
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.12-develop.7</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.12-develop.14</TerminalGuiVersion> |
There was a problem hiding this comment.
Keep the default pin on a validated Terminal.Gui build
When this line becomes the default, every project that references $(TerminalGuiVersion) restores Terminal.Gui 2.4.12-develop.14. The bump workflow/PR for this exact version reports that validation failed and that Editor still needs source changes, so merging only the pin leaves the normal CI and consumer build path broken; include the compatibility fixes with this bump or leave the default at 2.4.12-develop.7.
Useful? React with 👍 / 👎.
Automated bump of
TerminalGuiVersionfrom2.4.12-develop.7to2.4.12-develop.14failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.