Fix #18: re-anchor prompt after F7 history (Terminal.Gui v2)#19
Merged
Conversation
Port the Terminal.Gui v2 prompt-rendering fix from tui-cs/F7History#25 into PSTui's folded-in command-history handler. Under TG v2, Out-ConsoleGridView renders inline by default, so by the time the picker exits the screen has scrolled and PSReadLine's saved prompt row (_initialY) is stale. DeleteLine()/Render() then repaint the prompt in the wrong place. Call InvokePrompt($null, [Console]::CursorTop) first to re-anchor PSReadLine on the current cursor row, then DeleteLine + Insert as before. PSTui keeps DeleteLine (so the typed filter prefix is replaced, not appended) and drops the now-pointless SetCursorPosition dance, matching the upstream intent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18.
Pulls the Terminal.Gui v2 prompt-rendering fix from tui-cs/F7History#25 into PSTui's folded-in F7/Shift+F7 command-history handler (
Show-PSTuiHistory).Problem
Under Terminal.Gui v2,
Out-ConsoleGridViewrenders inline by default. By the time the picker exits, the screen has scrolled and PSReadLine's saved prompt row (_initialY) is stale. The oldDeleteLine()/Render()path then repaints the prompt in the wrong place.Fix
Call
InvokePrompt($null, [Console]::CursorTop)right after OCGV returns to re-anchor PSReadLine on the current cursor row, thenDeleteLine+Insertthe selection as before.PSTui keeps
DeleteLine(so the typed filter prefix is replaced, not appended — unlike the upstream PR which would append) and drops the now-pointlessSetCursorPositiondance.Test
Invoke-Build Build, Testgreen locally on pwsh 7.6 / .NET 10: 78 xUnit + 20 Pester pass.InvokePromptcall parses); F7/Shift+F7 bindings still registered.🤖 Generated with Claude Code