[feedback wanted] refactor: Limit BuildSettings usage to only String and [String] values#139
[feedback wanted] refactor: Limit BuildSettings usage to only String and [String] values#139waltflanagan wants to merge 1 commit intomainfrom
BuildSettings usage to only String and [String] values#139Conversation
869b66d to
e660b0a
Compare
I'd preserve the helpers from String to a specific type. I can see these being broadly useful. But yeah, otherwise, they should be represented as
Long-term, I'd like us to remove any Tuist specific pieces from XcodeGraph. XcodeGraph should be setup-agnostic and not Tuist-specific. So, if we can, I'd like us to look into removing these completely. |
|
@fortmarek do you think the |
Since we have some convenience methods for this in |
|
@fortmarek i ended up with this: tuist/XcodeProj@082545a I think it's a good compromise keeping the raw representation strict to what is read/written but allows things like |
|
Continuing this in #147 |
In working on tuist/XcodeProj#903 i've found that build settings defined in project files are always deserialized and
Stringand[String]types. Other types likeBoolorDictionaryare not representable within build settings. Even for boolean settings, Xcode encodes and decodes the strings"YES""NO".Secondarily, there are some things within
BuildSettings.swiftthat are specific to tuist behavior like default build settings for mergable libraries, and scheme generation. I'm not sure how these are intended to be used but as they are not part of a standardxcodeprojI don't believe we want to be attempting to read tuist value that are put into build settings.Opening this PR to start a conversation on the path forward related to these two topics.