This repository was archived by the owner on Feb 26, 2026. It is now read-only.
fix: fix project paths respecting nested projects#145
Merged
fortmarek merged 2 commits intotuist:mainfrom Mar 4, 2025
Merged
Conversation
fortmarek
reviewed
Mar 3, 2025
Member
fortmarek
left a comment
There was a problem hiding this comment.
I'm aligned with the fix, thanks @alexanderwe! Could you also write a small unit test for this? 🙏
Contributor
Author
Hey @fortmarek, good point, sorry that I forgot. I have added a small unit test with a workspace and two groups below it. Just let me know if this what you thought of or if I should enhance or slim it down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a small issue in the recursive build up on child projects in a XCWorkpace. When running
extractProjectPathson theXcodeGraphMapperand encountering a.groupthe groups location was not appended to the projects path. This results into incorrect paths for any child projects in the graph.🔎 Detailed explanation
An example
contents.xcworkspacedatawhich contains nested groups:With the current implementation, the
ModuleAproject path ends up to be<root>/ModuleAeven though it is part of aModulesdirectory.With the fix the path of the
ModuleAproject is correctly at<root>/Modules/ModuleA