feat(PBXFileReference): support XCFramework expectedSignature property#156
Conversation
dosubot
bot
added
the
size:M
| return .framework(path: path, status: status, condition: condition) | ||
| case .xcframework: | ||
| return .xcframework(path: path, status: status, condition: condition) | ||
| // TODO: throw some error? log warning? this is very general, but from what I can tell it's only called from a non-xcframework contexts |
There was a problem hiding this comment.
WDYT? Not sure how to treat this.
There was a problem hiding this comment.
Since this utility is being used from here where we can access the file reference through the build file, wouldn't we have the information that we need to set the right value here?
There was a problem hiding this comment.
Actually this seems OK now, there were some changes here following the review on tuist/tuist, and it makes sense now
From what I can tell, the path dependency mapper is used here (frameworks, no signature is required) and here (signature propagated, as expected)
So probably just need to remove the TODO
TamarMilchtaich
force-pushed
the
xcframeworks-expected-signature
branch
from
c367a1d to
5da3a82
Compare
|
Fixed & squashed the fixes into one commit |
Let's then wait until |
TamarMilchtaich
force-pushed
the
xcframeworks-expected-signature
branch
from
5da3a82 to
67d8b0c
Compare
|
Pushed the following change (and only this): |
TamarMilchtaich
force-pushed
the
xcframeworks-expected-signature
branch
2 times, most recently
from
ab00ad3 to
d609f81
Compare
TamarMilchtaich
force-pushed
the
xcframeworks-expected-signature
branch
from
d609f81 to
2fae634
Compare
|
Pushed the following change (and only this): |
TamarMilchtaich
force-pushed
the
xcframeworks-expected-signature
branch
from
2fae634 to
b1094a9
Compare
Support XCFrameworks expectedSignature property, and add the expected expectedSignature to the target dependency, to be verified against the actual signature.
pepicrft
force-pushed
the
xcframeworks-expected-signature
branch
from
5ce3dd5 to
f703041
Compare
Support XCFrameworks expectedSignature property, and add the expected expectedSignature to the target dependency, to be verified against the actual signature.
More about XCFramework's siganture:
https://developer.apple.com/documentation/Xcode/verifying-the-origin-of-your-xcframeworks