Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

feat: add default configuration name to the settings#196

Merged
fortmarek merged 5 commits intotuist:mainfrom
ImaginativeShohag:feat/default-configuration-settings
May 23, 2025
Merged

feat: add default configuration name to the settings#196
fortmarek merged 5 commits intotuist:mainfrom
ImaginativeShohag:feat/default-configuration-settings

Conversation

@ImaginativeShohag
Copy link
Contributor

This is the counter PR for tuist/tuist#7577

@pepicrft pepicrft requested review from Copilot and fortmarek May 20, 2025 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new default configuration name to the settings model.

  • Added an optional String property "defaultConfiguration" to the Settings struct.
  • Updated the initializer and the "with" function to accommodate the new property.

@pepicrft
Copy link
Contributor

Let's wait until this one is ready to merge this sone. Also, thoughts on the schema changes @fortmarek ?

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good here ✅

@ImaginativeShohag
Copy link
Contributor Author

As the other PR is ready and to pass the CI this PR needs to be merged.

@fortmarek
Copy link
Member

Thanks again for the contribution!

@fortmarek fortmarek merged commit aa28b75 into tuist:main May 23, 2025
7 checks passed
@ImaginativeShohag ImaginativeShohag deleted the feat/default-configuration-settings branch May 24, 2025 04:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants