Skip to content

Fix generate projects with external dependencies that have core data models#7323

Merged
fortmarek merged 2 commits intomainfrom
fix/external-with-core-data
Feb 17, 2025
Merged

Fix generate projects with external dependencies that have core data models#7323
fortmarek merged 2 commits intomainfrom
fix/external-with-core-data

Conversation

@fortmarek
Copy link
Copy Markdown
Member

Resolves #7319

Short description 📝

Core data models are handled by tuist as resources, however, a recent update in XcodeGraph caused core data models to be included as a source.

The actual fix is in: tuist/XcodeGraph#120

This PR solely updates the XcodeGraph dependency.

How to test the changes locally 🧐

  • tuist generate should work in the new app_with_exponea_sdk fixture.

Contributor checklist ✅

  • The code has been linted using run mise run lint-fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek force-pushed the fix/external-with-core-data branch from d911c6a to a43c15b Compare February 17, 2025 12:09
Comment thread Package.swift Outdated
),
.package(url: "https://github.com/tuist/Path", .upToNextMajor(from: "0.3.0")),
.package(url: "https://github.com/tuist/XcodeGraph.git", exact: "1.5.14"),
.package(url: "https://github.com/tuist/XcodeGraph.git", branch: "fix/model-extension"),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this to the released version of XcodeGraph once available.

@tuist
Copy link
Copy Markdown

tuist Bot commented Feb 17, 2025

🛠️ Tuist Run Report 🛠️

Tuist Tests 🧪

Command Status Cache hit rate Tests Skipped Ran Commit
test TuistApp -- CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO 0 % 0 0 0 e55440e4d
test TuistAutomationAcceptanceTests 0 % 0 0 0 e55440e4d
test TuistDependenciesAcceptanceTests 0 % 0 0 0 e55440e4d
test TuistGeneratorAcceptanceTests 0 % 0 0 0 e55440e4d
test TuistKitAcceptanceTests 0 % 0 0 0 e55440e4d
test TuistUnitTests 0 % 0 0 0 e55440e4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency with Core data fails in tuist generate

1 participant