[WIP] Add support for KWallet with SDDM at login#21
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Original prompt
Summary
Make KWallet unlock with SDDM at login, ensure Brave uses KWallet, add autostart for kwalletd5, and refactor some inline configuration into modules (power, kwallet). The PR should apply changes to hosts/nixos/configuration.nix and hosts/nixos/home.nix, add two modules under modules/nixos (power.nix and kwallet.nix), and ensure Brave desktop launcher points to the existing ~/.local/bin/brave wrapper and kwalletd5 starts automatically for graphical sessions.
Goals
Files to change
Replace or add the imports section (near the top imports array) to include the new modules. Example snippet to insert into the imports list:
Remove or comment out the old inline services.tlp = { ... } block and the inline environment.etc."pam.d/sddm".text block. The new modules will set the same options.
(If you prefer a more minimal module, we can simply export the exact services.tlp set as config.services.tlp.)
Notes: Because Nix merges environment.systemPackages lists, the module uses lib.concatLists to ensure kdePackages.kwallet and kdePackages.kwallet-pam are present. If this seems heavy-handed we can instead add a comment to leave the existing installs in configuration.nix.
Add the following entries in home.file or append them to the existing home.file entries:
Implementation details / rationale
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.