Get type checking from OlmMachine.shareRoomKey#338
Open
AndrewFerr wants to merge 8 commits intoturt2live:mainfrom
Open
Get type checking from OlmMachine.shareRoomKey#338AndrewFerr wants to merge 8 commits intoturt2live:mainfrom
AndrewFerr wants to merge 8 commits intoturt2live:mainfrom
Conversation
on account of it being removed from the crypto-sdk
OlmMachine.receiveSyncChanges returns an array of [device messages, room key changes], so emit "to_device.decrypted" with that instead of the entire array. Fixes regression introduced by turt2live#287.
Also condense the validity checks on the returned value
Update the rust-sdk bindings to have access to type checking in the return value of OlmMachine.shareRoomKey, which now returns an array of ToDeviceRequest objects instead of a JSON encoding of the whole array.
Contributor
Author
|
Note that this applies on top of #332 due to incrementing the rust-sdk version from that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the rust-sdk bindings to have access to type checking in the return value of OlmMachine.shareRoomKey, which now returns an array of ToDeviceRequest objects instead of a JSON encoding of the whole array.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Checklist