Stable Release of Autotype.#62
Conversation
|
@tushar5526 Looking for the approval. |
tushar5526
left a comment
tushar5526
left a comment
There was a problem hiding this comment.
docs/Makefile is empty ? Did it get committed accidentally?
| "progressbar2", | ||
| "colorama", | ||
| ] | ||
| requires-python = ">=3.9" |
There was a problem hiding this comment.
Ubuntu 20.04 comes with python 3.8 as default. Are there any major reason for deprecating support for python 3.8 ?
|
|
||
| - There are two themes in the GUI Script: Dark and Light. By clicking the toggle in the bottom left corner of the window, you can switch between the two. | ||
| <img src="https://imgur.com/NjLfWcL.gif)"> | ||
| pip3 install -r requirements-dev.txt |
There was a problem hiding this comment.
There is no requirements-dev.txt or requirements.txt. I see we are also not using pipenv and poetry for package management. What tool are we using here, is it pip?
| Put the text inside `code` in `Simulator/simulate_keyboard.py` as follows | ||
| pre-commit | ||
|
|
||
| pip3 install . |
There was a problem hiding this comment.
It is better to do an editable install for dev setup.
| from importlib import resources | ||
|
|
||
| try: | ||
| import tomllib |
There was a problem hiding this comment.
tomllib or tomli not included in pyproject.toml as dependencies. Doing an editable install locally is failing.
|
Let's move to poetry as well before making the release. It will probably not take much time (as we have very few dependencies) and ease the dev and deployment process. What are your thoughts @Mr-Sunglasses ? |
| ] | ||
| keywords = ["Autotype", "simulator", "commandline"] | ||
| dependencies = [ | ||
| "pynput", |
There was a problem hiding this comment.
It is better to fix the dependencies' version using ~ or ^ to avoid fails if a dependent dependencies stable version upgrades or does a major release. https://python-poetry.org/docs/dependency-specification/
tushar5526
left a comment
tushar5526
left a comment
There was a problem hiding this comment.
Reviewed with some comments
2 participants
Description
Please describe the changes in your pull request in few words here.
Changes
List the changes done to fix a bug or introducing a new feature.
How to test
Describe the steps required to test the changes proposed in the pull request.