Make play nice with https://github.com/guregu/null#6
Open
fwwieffering wants to merge 8 commits intotvi:masterfrom
Open
Make play nice with https://github.com/guregu/null#6fwwieffering wants to merge 8 commits intotvi:masterfrom
fwwieffering wants to merge 8 commits intotvi:masterfrom
Conversation
Generate random string for string type
Owner
|
Thank you for your PR. I will look at it over weekend |
mirusck
pushed a commit
to mirusck/datafiller
that referenced
this pull request
Jul 15, 2019
updated the go.sum which was still pulling in datafiller as a dependancy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Null* structs all contain a boolean field
Valid. This was getting filled randomly, which resulted in these fields being null when marshaled to JSON / db queries.Always set
Valid: trueforgopkg.in/guregu/null.v3.*packages