fix: stop opening .sln/.mts/.gsm developer files as media#84
Conversation
The Media file type registered raw and telephony audio extensions that collide with common developer files. Because the editor uses FileEditorPolicy.HIDE_DEFAULT_EDITOR, a matched file opens in the player with the text editor hidden, so the file cannot be viewed as text. - .sln (Asterisk signed-linear PCM) clobbered Visual Studio / Rider solution files (#78). Re-register the format under .slin, Asterisk's own non-colliding alias for the same headerless s16le stream, so raw signed-linear audio stays supported. - .mts (AVCHD transport stream) clobbered TypeScript ES-module sources. The container is still reachable via the already-registered .m2ts and .m2t, mirroring the earlier .ts removal (#45), so .mts is just dropped. - .gsm (raw GSM 06.10) clobbered ArchiCAD GDL objects; dropped. .au and .caf are kept: their only real alternative extensions (.snd, .caff) either collide worse (.snd vs X-Plane sound config) or do not reach actual files (.caff is effectively unused). Updates the three mirrored extension lists (frontend descriptor, MediaClassification, MediaTranscoder raw-audio hints) and adds regression tests locking .mts/.ts out of video and .slin (not .sln) as the signed-linear extension. Fixes #78
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdates shared media classification so ChangesMedia extension classification updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.1.3
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Removes the
.sln,.mts, and.gsmextensions that hijacked Visual Studio solution files, TypeScript sources, and ArchiCAD objects into the media player; raw signed-linear audio is re-registered under the non-colliding.slin. Fixes #78.Summary by CodeRabbit
slinextension.