refactor(backend): extract a shared ffmpeg-gate helper for the extract* RPCs

[twangodev]

Collapse the identical ffmpeg-availability + file-resolve + runCatching shell shared by extractWaveform/extractMediaInfo/extractSpectrogram into one private generic helper.

Summary by CodeRabbit

• Bug Fixes
  • Improved media extraction reliability by handling missing files, unavailable media tools, and extraction errors more gracefully.
  • Media details, waveform data, and spectrogram generation now return safe fallback values instead of failing unexpectedly.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eac7b8b3-0e6f-4c2f-961f-641ad327be33

📥 Commits

Reviewing files that changed from the base of the PR and between 3d3a088 and 733a7f5.

📒 Files selected for processing (1)

• backend/src/main/kotlin/dev/twango/jetplay/rpc/MediaAccessorImpl.kt

---

📝 Walkthrough

Walkthrough

A private generic suspend helper withFfmpegResolvedFile is added to MediaAccessorImpl, centralizing ffmpeg availability checking, file resolution, and runCatching error handling. The three existing RPC methods (extractWaveform, extractMediaInfo, extractSpectrogram) are refactored to delegate to this helper with their respective defaults.

MediaAccessorImpl Refactor

Layer / File(s)	Summary
Shared helper and method delegation backend/src/main/kotlin/dev/twango/jetplay/rpc/MediaAccessorImpl.kt	Adds withFfmpegResolvedFile generic suspend helper that gates on ffmpeg availability, resolves the source file, and wraps the extractor in runCatching; refactors all three extract* methods to use it with their respective defaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

A helper hops in, swift and neat,
Three methods now share the same beat.
Check ffmpeg, resolve the file,
Catch errors with rabbit-like guile.
🐇 Less duplication — oh, what a treat!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main refactor: sharing ffmpeg-gate logic across the extract* RPCs.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/mediaaccessor-extract-helper

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2026.1.3
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.