Skip to content

refactor(backend): drop TranscodeRunner pass-through, call MediaTranscoder directly#97

Merged
twangodev merged 2 commits into
mainfrom
refactor/drop-transcoderunner-wrapper
Jun 30, 2026
Merged

refactor(backend): drop TranscodeRunner pass-through, call MediaTranscoder directly#97
twangodev merged 2 commits into
mainfrom
refactor/drop-transcoderunner-wrapper

Conversation

@twangodev

Copy link
Copy Markdown
Owner

Remove the redundant TranscodeRunner object and call MediaTranscoder.transcode directly, matching the sibling extractors.

Copilot AI review requested due to automatic review settings June 29, 2026 23:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@twangodev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3fc43657-9eb0-4cfb-bac7-47e6cd14e931

📥 Commits

Reviewing files that changed from the base of the PR and between 3d3a088 and 3e9e7ad.

📒 Files selected for processing (3)
  • backend/src/main/kotlin/dev/twango/jetplay/rpc/MediaAccessorImpl.kt
  • backend/src/main/kotlin/dev/twango/jetplay/transcode/MediaTranscoder.kt
  • backend/src/main/kotlin/dev/twango/jetplay/transcode/TranscodeRunner.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/drop-transcoderunner-wrapper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2026.1.3
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@twangodev twangodev merged commit 6cd59ba into main Jun 30, 2026
15 checks passed
@twangodev twangodev deleted the refactor/drop-transcoderunner-wrapper branch June 30, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants