Skip to content

refactor(frontend): move JS payload encoders out of PlayerBridge into PlayerPayloads#99

Merged
twangodev merged 3 commits into
mainfrom
refactor/extract-player-payloads
Jun 30, 2026
Merged

refactor(frontend): move JS payload encoders out of PlayerBridge into PlayerPayloads#99
twangodev merged 3 commits into
mainfrom
refactor/extract-player-payloads

Conversation

@twangodev

Copy link
Copy Markdown
Owner

Extract the hand-rolled JS/JSON encoders (escapeJs, jsonString, mediaInfoJson, spectrogramJson) into an internal PlayerPayloads object so PlayerBridge stays a pure JCEF bridge and PlayerHtmlLoader no longer depends on the bridge type.

Copilot AI review requested due to automatic review settings June 29, 2026 23:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@twangodev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bc6518f0-cff1-470a-be12-d452d8c0c45e

📥 Commits

Reviewing files that changed from the base of the PR and between 3d3a088 and 5d799af.

📒 Files selected for processing (4)
  • frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt
  • frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerHtmlLoader.kt
  • frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerPayloads.kt
  • frontend/src/test/kotlin/dev/twango/jetplay/browser/PlayerBridgeEscapeTest.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/extract-player-payloads

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
Comment thread frontend/src/main/kotlin/dev/twango/jetplay/browser/PlayerBridge.kt Fixed
@github-actions

Copy link
Copy Markdown
Contributor

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2026.1.3
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

…line length

The PlayerPayloads prefix pushed showError past the 140-char limit;
caching the escaped string once shortens both emit lines and drops the
redundant double escape.
Copilot AI review requested due to automatic review settings June 30, 2026 00:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@twangodev twangodev merged commit f8c3af1 into main Jun 30, 2026
15 checks passed
@twangodev twangodev deleted the refactor/extract-player-payloads branch June 30, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants