Fix first filter for numbers#966
Merged
Merged
Conversation
`last` returns the last digit of a number since 74e681a, but `first` fell through to undefined and rendered an empty string. In TwigPHP both filters go through slice, which casts a scalar to a string, so `130|first` should yield "1". Add the missing Number branch to mirror `last`.
willrowe
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lastfilter was updated in 74e681a to return the last digit of a number, matching TwigPHP, but its counterpartfirstnever got the same treatment. As a result{{ 130|first }}renders an empty string while{{ 130|last }}renders0.In TwigPHP both filters run the value through
slice, which casts a scalar to a string before taking the substring, sofirstof a number is its first digit. This adds the missingNumberbranch tofirst, mirroring whatlastalready does, and adds a test next to the existinglastnumber test.