Add in the public $context property to the stream wrapper.#28
Open
adam-vessey wants to merge 1 commit intotwistor:masterfrom
Open
Add in the public $context property to the stream wrapper.#28adam-vessey wants to merge 1 commit intotwistor:masterfrom
public $context property to the stream wrapper.#28adam-vessey wants to merge 1 commit intotwistor:masterfrom
Conversation
|
I also landed here the same way @adam-vessey did. I'm now adding this package directly via composer and using cwegans/composer-patches to apply this patch. The "Deprecated function: Creation of dynamic property..." messages flooding my logs are gone. This gets a +1 from me. |
|
Thanks for this! Also came here via Drupal's flysystem module and installing twistor/flysystem-stream-wrapper with a patch from this PR seems to solve my problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should fix #27
Got here via
drupal/flysystem.It looks like the property should have been there for a long time (as in, added in PHP 5 days, according to the wayback machine), and is only being exposed now with the bump to PHP 8.2 being more strict with dynamic properties?