Migrate scalding from scalariform to scalafmt #1953
Merged
Merged
Conversation
Contributor
|
Nice! |
Contributor
|
Are we sure this is based on the latest code changes we landed on develop? It's very hard to review the whole diff. |
Contributor
|
looks like one of the job failed. Also, I wonder, are we using |
Contributor
Author
Yes, I applied it on top of develop. But given build failures I decided to split this change into config & preparation, and actual reformatting diff which is going to be just reformatting (and making CI fail if something not formatted properly). Now this change contains:
|
Contributor
Author
johnynek
approved these changes
Sep 26, 2021
tlazaro
approved these changes
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scala community migrated of scalariform towards scalafmt during last couple of years.
In this PR I've replaced scalariform with scalafmt in Scalding, used scalafmt config from algebird, and reformatted scalding repo.
I'm planning to follow up with another PR to enable scalafmt check on CI so it would be impossible to merge not formatted code.