Feature/storehaus cassandra only

[ghost]

As discussed in #211

[travisbrown]

Why not 2.2.5? Tests pass just fine on 2.2.5 with a couple of minor changes (that are arguably improvements, anyway).

[AndreasPetter]

2.2.5 doesn't seem to distinguish between scala 2.10.x any more. is it safe to assume that it will be working with all 2.10s?

[travisbrown]

@AndreasPetter It'll work with any 2.10 after 2.10.1.

[ianoc]

I think I'd rather we make a storehaus-contrib's repo and move these sorts of stores there. Any upgrades to support new scala versions to the core get blocked on lots of these external stores with questionable external support around them. I'd rather we have a core which we can be very confident about and the contrib repo people can update or not update as they like. I'm afraid of our builds being blocked by say flaky tests in elastic search that we know nothing about the code. Thoughts @johnynek ?

[travisbrown]

I'd recommend including the Case.Aux annotation here.

[AndreasPetter]

Sorry to bother you again, but I'm not able to bring "annotation" in useful context here - I'm not really a shapeless pro. What I do understand is that I use CaseBuilder (and therefore Case) under the hood by using at. I found an annotation.scala in shapeless but as far as I understand (and i must admit that i did not understand too much there) this is for witnessing annotations on types - for which I do not know how to use them here. Maybe you meant that it would be beneficial to add the Case.Aux implicit like implicit c: Case.Aux[T, CassandraPrimtive[T]]?

[AndreasPetter]

@travisbrown ah sorry, I just understood that you stated that it would be better to specify the return type with Case.Aux. Forget my previous comment, sorry.

[AndreasPetter]

Hm... Travis tests are failing, with the note "Killed". Since they run locally and no error shows up it is not unlikely that this has something to do with https://docs.travis-ci.com/user/common-build-problems/#My-build-script-is-killed-without-any-error . How do you arrange tests at Twitter if this happens?

[AndreasPetter]

O.k. I had to use the shaded cassandra driver (sorry @ianoc, there seem to be dependency conflicts with the driver with the other stores), and use an embedded Cassandra version for testing. Are there any more comments?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ianoc
❌ AndreasPetter
_{You have signed the CLA already but the status is still pending? Let us recheck it.}