Skip to content

feat: bump rust edition to 2024#770

Merged
scarmuega merged 4 commits into
mainfrom
bump-edition-2024
May 11, 2026
Merged

feat: bump rust edition to 2024#770
scarmuega merged 4 commits into
mainfrom
bump-edition-2024

Conversation

@scarmuega
Copy link
Copy Markdown
Member

Summary

  • Bump workspace edition from 2021 to 2024 now that MSRV is 1.88
  • Wrap unsafe operations in inner unsafe {} blocks (unsafe_op_in_unsafe_fn is a hard error in 2024)
  • Remove unnecessary ref binding modifier (edition 2024 match ergonomics)
  • Use use<T> syntax on impl Trait return to fix new lifetime capture rules
  • Hoist all crate-level edition to edition.workspace = true

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Warning

Rate limit exceeded

@scarmuega has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 1 second before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 028b1de6-0a6e-4383-b806-021849bdb1c1

📥 Commits

Reviewing files that changed from the base of the PR and between 3520353 and 524eb52.

📒 Files selected for processing (93)
  • Cargo.toml
  • examples/block-decode/Cargo.toml
  • examples/block-download/Cargo.toml
  • examples/block-download/src/main.rs
  • examples/crawler/Cargo.toml
  • examples/crawler/src/main.rs
  • examples/n2c-miniprotocols/Cargo.toml
  • examples/n2c-miniprotocols/src/main.rs
  • examples/n2n-miniprotocols/Cargo.toml
  • examples/n2n-miniprotocols/src/main.rs
  • examples/p2p-discovery/Cargo.toml
  • examples/p2p-discovery/src/node.rs
  • examples/p2p-discovery/src/otel.rs
  • examples/p2p-initiator/Cargo.toml
  • examples/p2p-initiator/src/main.rs
  • examples/p2p-responder/Cargo.toml
  • examples/p2p-responder/src/main.rs
  • examples/p2p-responder/src/otel.rs
  • examples/wallet/Cargo.toml
  • pallas-addresses/src/byron.rs
  • pallas-addresses/src/lib.rs
  • pallas-bech32/Cargo.toml
  • pallas-codec/src/flat/decode/error.rs
  • pallas-codec/src/lib.rs
  • pallas-codec/src/utils.rs
  • pallas-configs/src/alonzo.rs
  • pallas-configs/src/byron.rs
  • pallas-crypto/src/hash/serde.rs
  • pallas-crypto/src/kes/single_kes.rs
  • pallas-crypto/src/kes/summed_kes.rs
  • pallas-crypto/src/memsec.rs
  • pallas-hardano/src/display/haskell_display.rs
  • pallas-hardano/src/display/haskell_error.rs
  • pallas-hardano/src/display/haskells_show_string.rs
  • pallas-hardano/src/storage/immutable/mod.rs
  • pallas-math/src/math_dashu.rs
  • pallas-network/src/facades.rs
  • pallas-network/src/miniprotocols/blockfetch/codec.rs
  • pallas-network/src/miniprotocols/chainsync/buffer.rs
  • pallas-network/src/miniprotocols/chainsync/codec.rs
  • pallas-network/src/miniprotocols/common.rs
  • pallas-network/src/miniprotocols/handshake/n2c.rs
  • pallas-network/src/miniprotocols/handshake/n2n.rs
  • pallas-network/src/miniprotocols/handshake/protocol.rs
  • pallas-network/src/miniprotocols/keepalive/codec.rs
  • pallas-network/src/miniprotocols/localmsgnotification/client.rs
  • pallas-network/src/miniprotocols/localmsgnotification/codec.rs
  • pallas-network/src/miniprotocols/localmsgnotification/server.rs
  • pallas-network/src/miniprotocols/localmsgsubmission/codec.rs
  • pallas-network/src/miniprotocols/localstate/codec.rs
  • pallas-network/src/miniprotocols/localstate/queries_v16/codec.rs
  • pallas-network/src/miniprotocols/localstate/queries_v16/mod.rs
  • pallas-network/src/miniprotocols/localtxsubmission/codec.rs
  • pallas-network/src/miniprotocols/peersharing/codec.rs
  • pallas-network/src/miniprotocols/txmonitor/codec.rs
  • pallas-network/src/miniprotocols/txsubmission/client.rs
  • pallas-network/src/miniprotocols/txsubmission/codec.rs
  • pallas-network/src/miniprotocols/txsubmission/server.rs
  • pallas-network/src/multiplexer.rs
  • pallas-network/tests/plexer.rs
  • pallas-network/tests/protocols.rs
  • pallas-network2/Cargo.toml
  • pallas-primitives/src/alonzo/json.rs
  • pallas-primitives/src/alonzo/model.rs
  • pallas-primitives/src/babbage/model.rs
  • pallas-primitives/src/byron/model.rs
  • pallas-primitives/src/conway/model.rs
  • pallas-primitives/src/framework.rs
  • pallas-primitives/src/lib.rs
  • pallas-primitives/src/plutus_data.rs
  • pallas-traverse/src/auxiliary.rs
  • pallas-traverse/src/block.rs
  • pallas-traverse/src/header.rs
  • pallas-traverse/src/time.rs
  • pallas-traverse/src/witnesses.rs
  • pallas-txbuilder/src/conway.rs
  • pallas-txbuilder/src/lib.rs
  • pallas-txbuilder/src/transaction/model.rs
  • pallas-txbuilder/src/transaction/serialise.rs
  • pallas-utxorpc/src/lib.rs
  • pallas-validate/src/phase1/alonzo.rs
  • pallas-validate/src/phase1/babbage.rs
  • pallas-validate/src/phase1/conway.rs
  • pallas-validate/src/phase1/shelley_ma.rs
  • pallas-validate/src/phase2/error.rs
  • pallas-validate/src/phase2/to_plutus_data.rs
  • pallas-validate/src/phase2/tx.rs
  • pallas-validate/src/utils.rs
  • pallas-validate/tests/alonzo.rs
  • pallas-validate/tests/babbage.rs
  • pallas-validate/tests/byron.rs
  • pallas-validate/tests/conway.rs
  • pallas-validate/tests/shelley_ma.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-edition-2024

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit 99febf9 into main May 11, 2026
10 checks passed
@scarmuega scarmuega deleted the bump-edition-2024 branch May 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant