Skip to content

refactor: wave 6 — ratchet mypy coverage + link clean-code standard #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ty13r merged 1 commit into from
Apr 19, 2026
Merged

refactor: wave 6 — ratchet mypy coverage + link clean-code standard #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ Core loop: `skillforge/engine/evolution.py` (molecular) + `skillforge/engine/var

## Key Reference Documents
- `docs/how-skld-works.md` — **start here**: full system overview for first-time readers.
- `docs/clean-code.md` — the review rubric every PR is held to (naming, functions, errors, data, async, functional idioms, React/TS, testing, comments, checklist).
- `plans/SPEC-V2.0.md` — v2.0 architecture spec (taxonomy, agents, variants, evaluation, data model).
- `plans/PLAN-V2.0.md` — v2.0 implementation plan (5 phases, 15 waves, file-by-file).
- `plans/SPEC-V2.1.md` — v2.1 architecture spec (controlled evaluation environments, tiered challenge pools, train/test separation).
Expand Down Expand Up @@ -181,11 +182,17 @@ When running autonomously (overnight work, no active user):
- **On hard block**: document in Progress Tracker with `[BLOCKED: reason]` marker, write a journal entry explaining what was tried, skip to any independent work, stop cleanly if no independent work remains.

## Code Style
Full rubric: **`docs/clean-code.md`**. TL;DR:
- Type hints everywhere. Dataclasses for internal models, Pydantic only at API boundary.
- Async throughout — evolution engine is fully async.
- No classes where functions suffice.
- Short functions, clear names, minimal comments.
- Short functions (≤50 lines), clear names, minimal comments.
- Prefer composition over inheritance.
- No bare `except Exception` — typed exceptions from `skillforge/errors.py`.
- No `print` in library code — `logging` module with `logger.exception` inside excepts.
- No mutable module globals — use `skillforge/engine/run_registry.py` or similar injected state.
- No raw `fetch()` in React components — typed hooks from `frontend/src/api/hooks/`.
- File ceilings: 500 LOC (Python), 400 LOC (TSX). Split into packages when they grow.

## Testing
- Unit tests mock the Agent SDK.
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ exclude = [
"^skillforge/engine/evolution\\.py$",
"^skillforge/engine/export\\.py$",
"^skillforge/engine/sandbox\\.py$",
"^skillforge/engine/scorer\\.py$",
"^skillforge/main\\.py$",
"^skillforge/models/run\\.py$",
]
Expand Down
Loading