Open
Conversation
added 7 commits
March 8, 2026 01:16
Author
|
The current implementation renders the toggle (and the initialization script) by default, which changes the generated html structure and causes several Helium html tests to fail due to expected output differences. I have checked functionally everything works as intended in the browser. Would like to check whether enabling the toggle by default ( which would require updating a whole bunch of tests) is preferred, or if it should instead be opt in via Helium configuration flag, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #382
Helium currently supports dark mode but users cannot manually override it per site.
This PR adds a manual color mode toggle to the Helium theme. Users can switch between
Auto(followprefers-color-scheme),Light, andDark. The selected mode is stored locally in the browser usinglocalStorageand persists across page navigations. If no selection is made, the default isAutowhich follows the system/browser preference, and no personal or identifying data is stored. The toggle button is placed on top left navigation bar.Testing: checked
Autodoes follow browser default, and Light/Dark mode switch is working.Example ( using the protosearch doc)

