Skip to content

Fix linesLimited bypass when line completes in one chunk - #3756

Open
arimu1 wants to merge 1 commit into
typelevel:mainfrom
arimu1:fix/linesLimited-single-chunk-max-length
Open

Fix linesLimited bypass when line completes in one chunk#3756
arimu1 wants to merge 1 commit into
typelevel:mainfrom
arimu1:fix/linesLimited-single-chunk-max-length

Conversation

@arimu1

@arimu1 arimu1 commented Aug 13, 2026

Copy link
Copy Markdown

Summary

Fixes #3725

Test plan

  • sbt "coreJVM/testOnly fs2.TextSuite" — 92 tests passed (JDK 17)
  • New test: linesLimited rejects long lines completed in a single chunk

Made with Cursor

Check completed lines in linesBuffer against maxLineLength, not only
the pending stringBuilder. Add regression test for single- vs multi-chunk input.

Fixes typelevel#3725
@arimu1
arimu1 force-pushed the fix/linesLimited-single-chunk-max-length branch from e32c112 to 2bc6c2a Compare August 13, 2026 00:19
@arimu1

arimu1 commented Aug 14, 2026

Copy link
Copy Markdown
Author

Note for maintainers/CI watchers: the red root* / Native jobs on the opening push look like GitHub Actions infra (Homebrew unknown install step: run / bootstrap), not product assertions from this change. Local TextSuite was green when opened. Happy to re-run when the matrix is healthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

text.linesLimited lets through arbitrarily long lines when the line and its terminator land in the same chunk

1 participant