Fix linesLimited bypass when line completes in one chunk - #3756
Open
arimu1 wants to merge 1 commit into
Open
Conversation
Check completed lines in linesBuffer against maxLineLength, not only the pending stringBuilder. Add regression test for single- vs multi-chunk input. Fixes typelevel#3725
arimu1
force-pushed
the
fix/linesLimited-single-chunk-max-length
branch
from
August 13, 2026 00:19
e32c112 to
2bc6c2a
Compare
Author
|
Note for maintainers/CI watchers: the red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text.linesLimitedonly checkedstringBuilder.lengthafter processing each chunk, so lines flushed intolinesBufferinsidefillBuffers(when a line and its terminator arrive in the same chunk) bypassed the limit.linesBufferas well as the pending builder before emitting output.Fixes #3725
Test plan
sbt "coreJVM/testOnly fs2.TextSuite"— 92 tests passed (JDK 17)linesLimited rejects long lines completed in a single chunkMade with Cursor