Aws cloud log group name add in trace#1017
Open
ChristyGKrishnan wants to merge 7 commits intotypelevel:mainfrom
Open
Aws cloud log group name add in trace#1017ChristyGKrishnan wants to merge 7 commits intotypelevel:mainfrom
ChristyGKrishnan wants to merge 7 commits intotypelevel:mainfrom
Conversation
bpholt
reviewed
Jun 20, 2024
| * `aws_group_name` key in the annotations, when present, sets the AWS CloudWatch log group name. | ||
| * It is used to add log details to each trace. | ||
| */ | ||
| val logGroupValue = allAnnotations.get("aws_group_name") |
Member
There was a problem hiding this comment.
Is this likely to be the same value for all spans in a given application? Or is it possible to vary on a per-span basis?
If it's going to be the same for all spans in an application, I wonder if it's better set as an option on XRayEntryPoint (perhaps via XRayEnvironment) and then propagated here? Otherwise won't users have to set this every time they want to add a log to a span?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail description in issue