Pass span options in RootsSpan#818
Merged
mpilquist merged 1 commit intotypelevel:mainfrom Jun 30, 2023
Merged
Conversation
kubukoz
approved these changes
Jun 27, 2023
armanbilge
approved these changes
Jun 28, 2023
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
I guess this was just an oversight?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to ask if there is any reason why the
Span.Optionsare not passed fromRootsSpan? CurrentlyRootsSpanis only used forIOLocalbased implementation, but if typelevel/natchez-http4s#34 is accepted, it will be needed for bothIOLocalandKleislito propagate options fromRootsSpancorrectly.