Add typing#8
Draft
dontinelli wants to merge 1 commit intoualex73:masterfrom
Draft
Conversation
Contributor
Author
|
@ualex73, any thoughts on this? |
Owner
|
Hi dontelli,
This week I do not have time to look at it, next week I most likely have
time for it.
Op wo 7 mei 2025 om 14:59 schreef dontinelli ***@***.***>
… *dontinelli* left a comment (ualex73/goslide-api#8)
<#8 (comment)>
@ualex73 <https://github.com/ualex73>, any thoughts on this?
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQASXH7BDX4L4YTDQASZ2325H7TVAVCNFSM6AAAAABUZNV2T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJYGUYDAMRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typing to the library, in order to eventually enable strict typing in HA integration (https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/strict-typing). Together with the shared session (#7), this would enable the platin rating in the HA quality scale.
This is a first step, in a second step I would suggest to use data models to handle the received data instead of dicts. Furthermore, I noticed that the request-routines (may) return None. I think it would make things easier, if return value is always given, and if no correct value has been received, an exception is thrown. But again, this would be for a follow-up PR.
Let me know your thoughts, before I invest further time in this.