Rebase to v146

[uazo]

Description

Rebase to v146

All submissions

• there are no other open Pull Requests for the same update/change
• Cromite can be built with these changes
• I have tested that the new change works as intended (AVD or physical device will do)

Format

• patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
• patch description contains explanation of changes
• no unnecessary whitespace or unrelated changes

[PF4Public]

They've added another style rule in chromium/chromium@37c28a1 it seems:

third_party/node/node_modules/stylelint/bin/stylelint.mjs --color --config ../../ui/webui/resources/tools/stylelint.config_base.mjs gen/components/webui/flags/resources/preprocessed/app.css gen/components/webui/flags/resources/preprocessed/experiment.css' failed
stderr:

gen/components/webui/flags/resources/preprocessed/app.css
  390:1  ✖  Expected empty line before rule  rule-empty-line-before
  393:1  ✖  Expected empty line before rule  rule-empty-line-before
  396:1  ✖  Expected empty line before rule  rule-empty-line-before
  399:1  ✖  Expected empty line before rule  rule-empty-line-before
  402:1  ✖  Expected empty line before rule  rule-empty-line-before
  405:1  ✖  Expected empty line before rule  rule-empty-line-before
  408:1  ✖  Expected empty line before rule  rule-empty-line-before
  411:1  ✖  Expected empty line before rule  rule-empty-line-before

✖ 8 problems (8 errors, 0 warnings)
  8 errors potentially fixable with the "--fix" option.


exit=2

[uazo]

Hi @PF4Public, if only that were all! :)

This release is challenging, I currently have 133 files modified and I'm not done yet...

Android crashes on startup and Windows still won't compile...
It will probably take me longer than usual.

[PF4Public]

Hi @PF4Public, if only that were all! :)

Yeah, I encountered other issues trying to build cromite for Linux from this PR.

[uazo]

@PF4Public The latest commit resolves all issues with the desktop build.

Unfortunately, for Android, the bottom bar is still having a few problems. I’ve decided to modify it to align with the Chromium implementation, so, unfortunately, I’m not finished yet.

[alk3pInjection]

cromite/build/patches/Move-navigation-bar-to-bottom.patch

Line 3207 in 31d4039

+#if BUILDFLAG(IS_ANDROID)SET_CROMITE_FEATURE_DISABLED(kAndroidBrowserControlsInViz);

missing \n here

[alk3pInjection]

btw the component updater patch forgot to update the function call in chromedriver as well

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index acedd655ce..f58bd07b32 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -1112,7 +1112,7 @@ Status ProcessExtension(const std::string& extension,
     crx_file::VerifierResult result = crx_file::Verify(
         extension_crx, crx_file::VerifierFormat::CRX3,
         {} /** required_key_hashes */, {} /** required_file_hash */,
-        &public_key_base64, &id, /*compressed_verified_contents=*/nullptr);
+        &public_key_base64, &id, /*compressed_verified_contents=*/nullptr, /*is_extension*/true);
     if (result == crx_file::VerifierResult::ERROR_HEADER_INVALID) {
       return Status(kUnknownError,
                     "CRX verification failed to parse extension header. Chrome "

I should have reported this earlier but better late than never ^^

[uazo]

@alk3pInjection Yes, you're right.
If you're interested, this is missing from the patch to fully work:

+++ b/components/viz/common/features.cc
@@ -33,7 +33,7 @@
 
 namespace features {
 
-#if BUILDFLAG(IS_ANDROID)SET_CROMITE_FEATURE_DISABLED(kAndroidBrowserControlsInViz);
+#if BUILDFLAG(IS_ANDROID)
 
 // If this flag is enabled, a DumpWithoutCrashing() is captured when a bad
 // state is detected when moving the composited UI. For example, this could

+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/BrowserControlsManager.java
@@ -315,6 +316,13 @@ public class BrowserControlsManager implements ActivityStateListener, BrowserCon
                                 new OffsetTagConstraints(
                                         0, 0, -(mTopControlsHeight + hairlineHeight), 0);
 
+                        if (ChromeFeatureList.sMoveTopToolbarToBottom.isEnabled()) {
+                            offsetTagsInfo.mTopControlsConstraints =
+                                    new OffsetTagConstraints(
+                                            0, 0, 0, mTopControlsHeight + hairlineHeight);
+                        }
                         onConstraintsChanged(constraints);
                         // Notify observers of changes before passing tags to native so observers
                         // can set their relevant fields in offsetTagsInfo.

By the way, now that I’ve completely messed up my development environment by reverting my patch, the bug I mentioned is actually in the original Chromium implementation!

Well, I’ve never seen a release so full of messy, half-finished code, where things only work if you find the right combination of flags to activate... And if you go and look at the bugid, you’ll find they’re all restricted, and if you ask for them to be made public, they act like the bureaucracy, sending you from one desk to another…

If this is a sign of things to come for future releases – given that they’re cutting the time between each release in half – we’re in for a real treat...

btw the component updater patch forgot to update the function call in chromedriver as well

Which target (I mean the gn target) are you building?

[alk3pInjection]

..snip..

By the way, now that I’ve completely messed up my development environment by reverting my patch, the bug I mentioned is actually in the original Chromium implementation!

thank you for your amazing hard work!

If this is a sign of things to come for future releases – given that they’re cutting the time between each release in half – we’re in for a real treat...

I second this.

Which target (I mean the gn target) are you building?

gn gen out/Release --args="${_flags[*]}"
ninja -C out/Release chrome chrome_sandbox chromedriver.unstripped

my build script is at alk3p/cromite

[Orthoxodus]

Ask @gonzazoid