Add VictoriaMetrics support #279
Closed
jay-mckay wants to merge 2 commits into
Closed
Conversation
Author
|
#273 It looks like the changes made here would actually solve this issue, I did not see this before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our site uses VictoriaMetrics as our TSDB. VictoriaMetrics supports the Prometheus v1 Query API, but provides it at a different path ,
/select/ID/prometheus. The hard coded leading slash in the endpoints mangles this path when joined with the base URL.By removing the leading slash, and providing the full path in the config,
https://host:port/select/0/prometheus/, we have been able to use VictoriaMetrics with Supremm.Additionally, we think that the configuration file parameter should just be the full URL, and not the host, so we can use HTTPS.
This should not have any affect on the Prometheus setups.
As far as testing, I could not quite get the testing environment set up - but we have been summarizing jobs this way for a few weeks.