Add support for deprecated names, raise warning instead of error for unknown filter values, refactor descriptors code.#91
Draft
aaronweeden wants to merge 11 commits into
Draft
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on [upcoming PR in
xdmod] that will need to be merged first for the CI tests to pass on this one.Description
This PR does the following:
xdmod), where the XDMoD portal can mark names of realms, metrics, dimensions, and/or raw fields as deprecated, andxdmod-datawill throw aFutureWarningif it is used while using the updated name for its requests to the portal.Motivation and Context
See [upcoming PR in
xdmod].Tests performed
This PR updates the integration tests to make sure:
FutureWarningis properly raised for a deprecated raw field.UserWarninginstead of aKeyError.Type of change:
Checklist:
xdmod-notebooksrepository as necessary, and the notebooks all run successfully