Better tests and documentation#7
Open
maxdudek wants to merge 12 commits into
Open
Conversation
Contributor
maxdudek
commented
Jun 28, 2019
maxdudek
commented
- Rewrote script which generates test data to be easily configurable
- Added documentation for replacement rules config file
- Memory is now converted from MB to GB in the supremm transform step, meaning the ingest step no longer has to worry about it.
jpwhite4
requested changes
Aug 2, 2019
| "cpu_id": "ct.id", | ||
| "core_count": "s.core_count", | ||
| "memory_gb": "CEILING(s.physmem / 1024.0)", | ||
| "memory_gb": "s.physmem", |
Member
There was a problem hiding this comment.
Please can you confirm that this change is intentional. Where does the memory value normalization occur now?
Contributor
Author
There was a problem hiding this comment.
Yes, the memory gets converted in the 'transform' step of the SUPReMM archive reader (get_hardware_info.py), although it (temporarily) is also taken care of by the SUPReMM patching script, so that data extracted before this change also gets converted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.