Bryson/pr vision ros params#77
Conversation
…iable isDynRecon actually updates to the correct value
…ile on our personal computer
… to the if statement problem
… of a yaml file outout from the python
…les after killing it.
…m's fix of the test
newtoncn
left a comment
newtoncn
left a comment
There was a problem hiding this comment.
Looks good, there was just one thing to address
| f = boost::bind(&HSVFilterNode::dynamicreconfigCallback, this, _1, _2); | ||
| server.setCallback(f); | ||
| } else { | ||
| // If the Dynamic Reconfigure is not desired, then set all the |
There was a problem hiding this comment.
Do we need this resetting of the parameters? If not can we take it out
There was a problem hiding this comment.
It is not needed. I only added it there so that the values in the "params server" would be consistent with the actual values being used in the node. In terms of functionality, it is not necessary. Feel free to take out the code within that else block.
garethellis0
left a comment
garethellis0
left a comment
There was a problem hiding this comment.
Looks pretty sane to me overall
| // Once the node stops, return 0 | ||
| // Once the node stops, return 0 | ||
| return 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
nit github complaining about end-of-file
There was a problem hiding this comment.
github is still complaining?
|
@brysonmarazzi @danaharlos Also code needs to be merged into master as master has been updated. |
garethellis0
left a comment
garethellis0
left a comment
There was a problem hiding this comment.
Apologies for the late review. One end-of-file issue left, but other then that this LGTM 👍 🎉
4 participants
This is an updated version of the vision hsv_filter_node rosparams pull request.
I created python script that gets run upon exiting the hsv_filter_node. The python script "yamlEditor.py" (in the cfg directory) edits the messy yaml file exported by the rqt_reconfiguration gui and creates a new yaml file that the launch file can then load into the rosparam server. I also added an arguments tag in the lunauh file so now you can call the node with the "is_dyn_recon" variable set to true or default to false if it is not passed to the launch file.
This should increase the efficiency of dynamically editing the hsv_filter_node parameters.