Downgrade PortUnreachableException in UDP flush from an exception to a warn log.#132
Merged
adamjeanlaurent merged 6 commits intomasterfrom Dec 12, 2025
Merged
Conversation
|
|
adamjeanlaurent
commented
Dec 11, 2025
adamjeanlaurent
commented
Dec 11, 2025
adamjeanlaurent
changed the title
roman-mazhut
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PortUnreachableException in the UDP flush is expected if the downstream metric collection service is not available. For the client library, it is not an not an issue that is actionable. At Uber our metrics collector can become overloaded and OOM or is otherwise temporarily unavailable during container upgrades, and PortUnreachableException causes a lot of noise and triggers alerts and deployment rollbacks for services. Downgrading it from an exception to a warn log.