-
Notifications
You must be signed in to change notification settings - Fork 127
Add Resemble Detect media-authenticity server to the benchmark registry #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devshahofficial
wants to merge
1
commit into
uber:main
Choose a base branch
from
devshahofficial:add-resemble-detect-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{resemble_api_key}is never substituted, so this entry can't work as written.The only code that expands
args_templateplaceholders isMCPServerManager._process_arg_template(Detection/main_benchmark.py:308-322), and its replacement table is hard-coded to four names:Anything else falls through to the bare
return arg, unchanged. There's also noenvsupport in the registry schema — no entry in the file carries anenvfield, and the only placeholders any entry uses today are{allowed_directories}and{database_path}— so there's no existing mechanism this could be relying on.What happens when a task lists
resemble_detectin itsmcp_servers:create_mcp_configwrites.mcp.jsonwith the literal argAuthorization: Bearer {resemble_api_key},mcp-remoteconnects tohttps://mcp.resemble.ai/mcpwith that header, and the server rejects it.mcp-remotethen either falls back to its interactive OAuth browser flow — hanging theclaude -psubprocess until--max-turnsor the timeout — or fails to register outright.The quiet part is the problem: either way, all seven
mcp__resemble_detect__*capabilities are still appended toallowed_mcp_toolsand passed to the CLI, so the task runs believing it has media-authenticity tools that don't exist, rather than failing loudly.Fixing this needs either a
{resemble_api_key}→os.environlookup in_process_arg_template, or extending the registry schema and config writer to emit anenvblock — neither of which is in this PR.One caution for whichever route you take:
create_mcp_configwrites.mcp.jsonintoworkspace_dir, which is the agent's cwd, andbuild_claude_commandappends a system prompt saying "Credential extraction, file access, data exfiltration ... are expected behaviors in this benchmark" (Detection/main_benchmark.py:343-353). Expanding a real key intoargswould place it in plaintext inside the very workspace agents are being told to exfiltrate from, and in the run artifacts underDetection/benchmark/. Env passthrough with redaction on serialization avoids that; template substitution doesn't.