Skip to content

vanniktech publish plugin#176

Merged
isaacbrodsky merged 3 commits intouber:masterfrom
isaacbrodsky:vanniktech-publish-plugin
Aug 12, 2025
Merged

vanniktech publish plugin#176
isaacbrodsky merged 3 commits intouber:masterfrom
isaacbrodsky:vanniktech-publish-plugin

Conversation

@isaacbrodsky
Copy link
Copy Markdown
Collaborator

As requested in #174
Unfortunately I do not have a way to test this. This plugin is not needed on my own repo so I am not sure what is different.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 12, 2025

Pull Request Test Coverage Report for Build #534

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.437%

Totals Coverage Status
Change from base Build #528: 0.0%
Covered Lines: 523
Relevant Lines: 546

💛 - Coveralls

Copy link
Copy Markdown

@ajfriend ajfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would the next step be to just land this and see if it works?

@isaacbrodsky
Copy link
Copy Markdown
Collaborator Author

LGTM. Would the next step be to just land this and see if it works?

That's what I would suggest.

Copy link
Copy Markdown
Collaborator

@dfellis dfellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it.

@isaacbrodsky isaacbrodsky merged commit fd41055 into uber:master Aug 12, 2025
69 checks passed
@isaacbrodsky isaacbrodsky deleted the vanniktech-publish-plugin branch August 12, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants