Conversation
Pull Request Test Coverage Report for Build #592Details
💛 - Coveralls |
ajfriend
approved these changes
Nov 8, 2025
dfellis
reviewed
Dec 12, 2025
dfellis
approved these changes
Dec 12, 2025
ajfriend
reviewed
Dec 12, 2025
| void test() { | ||
| Set<String> messages = new HashSet<>(); | ||
| int maxErrorCode = 16; | ||
| int maxErrorCode = 20; |
There was a problem hiding this comment.
Not at all blocking for this PR, but I wonder if it would be useful to have a function that returns H3_ERROR_END in the C lib that the bindings could call.
For the Python bindings, Cython can't read the H3ErrorCodes struct directly and we need to encode it by hand in https://github.com/uber/h3-py/blob/f9c1a944d1be1c78e713939c00a70c60dd5219bc/src/h3/_cy/h3lib.pxd#L15-L36, so it can be invalid if I forget to update it. A helper function that returns H3_ERROR_END would provide a way to do a more robust check for that scenario.
ajfriend
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.