Skip to content

Component.name optimized: replace String(describing:) with _typeName #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisBenua wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −10
Open

Component.name optimized: replace String(describing:) with _typeName #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions Sources/NeedleFoundation/Component.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,7 @@ open class Component<DependencyType>: Scope {

private let sharedInstanceLock = NSRecursiveLock()
private var sharedInstances = [String: Any]()
private lazy var name: String = {
let fullyQualifiedSelfName = String(describing: self)
let parts = fullyQualifiedSelfName.components(separatedBy: ".")
return parts.last ?? fullyQualifiedSelfName
}()
private lazy var name: String = _typeName(type(of: self), qualified: false)
Copy link

@listrophy listrophy Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, but it uses a private API. Up to the maintainers to decide if that's ok

Copy link
Author

@ChrisBenua ChrisBenua Jan 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not truly private API. This function is public but not documented.

Moreover, it can be accessed indirectly by calling regular string interpolation. Like "\(type(of: self))"


// TODO: Replace this with an `open` method, once Swift supports extension
// overriding methods.
Expand Down Expand Up @@ -270,11 +266,7 @@ open class Component<DependencyType>: Scope {

private let sharedInstanceLock = NSRecursiveLock()
private var sharedInstances = [String: Any]()
private lazy var name: String = {
let fullyQualifiedSelfName = String(describing: self)
let parts = fullyQualifiedSelfName.components(separatedBy: ".")
return parts.last ?? fullyQualifiedSelfName
}()
private lazy var name: String = _typeName(type(of: self), qualified: false)

// TODO: Replace this with an `open` method, once Swift supports extension
// overriding methods.
Expand Down