rebased main because files moved

Author: ubettigole

submitqueue/extension/changeprovider/phabricator/BUILD.bazel

@@ -10,8 +10,8 @@ go_library(
     importpath = "github.com/uber/submitqueue/submitqueue/extension/changeprovider/phabricator",
     visibility = ["//visibility:public"],
     deps = [
-        "//core/metrics",
-        "//entity/change/phabricator",
+        "//platform/base/change/phabricator",
+        "//platform/metrics",
         "//submitqueue/entity",
         "//submitqueue/extension/changeprovider",
         "@com_github_uber_go_tally//:tally",
@@ -28,8 +28,8 @@ go_test(
     ],
     embed = [":phabricator"],
     deps = [
-        "//entity/change",
-        "//entity/change/phabricator",
+        "//platform/base/change",
+        "//platform/base/change/phabricator",
         "//submitqueue/entity",
         "//submitqueue/extension/changeprovider",
         "@com_github_stretchr_testify//assert",

submitqueue/extension/changeprovider/phabricator/convert.go

@@ -3,12 +3,12 @@ package phabricator
 import (
 	"strconv"
 
-	entityphab "github.com/uber/submitqueue/entity/change/phabricator"
+	changephab "github.com/uber/submitqueue/platform/base/change/phabricator"
 	"github.com/uber/submitqueue/submitqueue/entity"
 )
 
 // convertToChangeInfo converts a Phabricator diff result to an entity.ChangeInfo.
-func convertToChangeInfo(parsed entityphab.ChangeID, diff *diffResult) entity.ChangeInfo {
+func convertToChangeInfo(parsed changephab.ChangeID, diff *diffResult) entity.ChangeInfo {
 	return entity.ChangeInfo{
 		URI: parsed.String(),
 		Details: entity.ChangeDetails{

submitqueue/extension/changeprovider/phabricator/convert_test.go

@@ -5,12 +5,12 @@ import (
 
 	"github.com/stretchr/testify/assert"
 
-	entityphab "github.com/uber/submitqueue/entity/change/phabricator"
+	changephab "github.com/uber/submitqueue/platform/base/change/phabricator"
 	"github.com/uber/submitqueue/submitqueue/entity"
 )
 
 func TestConvertToChangeInfo(t *testing.T) {
-	parsed := entityphab.ChangeID{Scheme: "phab", RevisionID: 12345, DiffID: 100}
+	parsed := changephab.ChangeID{Scheme: "phab", RevisionID: 12345, DiffID: 100}
 	diff := &diffResult{
 		AuthorName:  "Alice",
 		AuthorEmail: "alice@example.com",

submitqueue/extension/changeprovider/phabricator/provider.go

@@ -8,8 +8,8 @@ import (
 	"github.com/uber-go/tally"
 	"go.uber.org/zap"
 
-	coremetrics "github.com/uber/submitqueue/core/metrics"
-	entityphab "github.com/uber/submitqueue/entity/change/phabricator"
+	changephab "github.com/uber/submitqueue/platform/base/change/phabricator"
+	coremetrics "github.com/uber/submitqueue/platform/metrics"
 	"github.com/uber/submitqueue/submitqueue/entity"
 	"github.com/uber/submitqueue/submitqueue/extension/changeprovider"
 )
@@ -53,9 +53,9 @@ func (p *provider) Get(ctx context.Context, request entity.Request) (_ []entity.
 
 	change := request.Change
 
-	changeIDs := make([]entityphab.ChangeID, 0, len(change.URIs))
+	changeIDs := make([]changephab.ChangeID, 0, len(change.URIs))
 	for _, uri := range change.URIs {
-		parsed, err := entityphab.ParseChangeID(uri)
+		parsed, err := changephab.ParseChangeID(uri)
 		if err != nil {
 			return nil, fmt.Errorf("failed to parse Phabricator change ID %q: %w", uri, err)
 		}
@@ -93,7 +93,7 @@ func (p *provider) Get(ctx context.Context, request entity.Request) (_ []entity.
 }
 
 // fetchAllDiffs fetches diff data for all change IDs in batches of queryDiffsBatchSize.
-func (p *provider) fetchAllDiffs(ctx context.Context, changeIDs []entityphab.ChangeID) (map[int]*diffResult, error) {
+func (p *provider) fetchAllDiffs(ctx context.Context, changeIDs []changephab.ChangeID) (map[int]*diffResult, error) {
 	diffIDs := make([]int, 0, len(changeIDs))
 	for _, cid := range changeIDs {
 		diffIDs = append(diffIDs, cid.DiffID)

submitqueue/extension/changeprovider/phabricator/provider_test.go

@@ -13,7 +13,7 @@ import (
 	"github.com/uber-go/tally"
 	"go.uber.org/zap/zaptest"
 
-	"github.com/uber/submitqueue/entity/change"
+	"github.com/uber/submitqueue/platform/base/change"
 	"github.com/uber/submitqueue/submitqueue/entity"
 	"github.com/uber/submitqueue/submitqueue/extension/changeprovider"
 )